Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Logger UX improvements #6222

Merged
merged 30 commits into from
Aug 28, 2024
Merged

🎨 [Frontend] Logger UX improvements #6222

merged 30 commits into from
Aug 28, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 22, 2024 •
edited
Loading

What do these changes do?

  • Wrap long texts, and when clicking on the line, extend it
  • Allow coping one log line
  • If a search is applied, download only logs corresponding to the search
  • Switch the log-lock's bahaviour
  • Clicking on the failed status chip in the node, brings you to the logger and filters that node

Logger

FailedNode

Related issue/s

closes ITISFoundation/osparc-issues#1487
closes ITISFoundation/osparc-issues#1139
closes ITISFoundation/osparc-issues#651
related to ITISFoundation/osparc-issues#1684

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Aug 22, 2024
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) UX_improvements UX Feedback during frontend testing process labels Aug 22, 2024
@odeimaiz odeimaiz changed the title wrap text [Frontend] Logger UX improvements Aug 22, 2024
@odeimaiz odeimaiz changed the title [Frontend] Logger UX improvements 🎨 [Frontend] Logger UX improvements Aug 22, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Aug 26, 2024
@odeimaiz odeimaiz marked this pull request as ready for review August 27, 2024 14:49
@odeimaiz odeimaiz enabled auto-merge (squash) August 27, 2024 14:50
pcrespov
pcrespov approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very welcomed! thx!

services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js Outdated Show resolved Hide resolved
sanderegg
sanderegg approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it! mesmerizing!

services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js Outdated Show resolved Hide resolved
@odeimaiz odeimaiz disabled auto-merge August 28, 2024 06:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz merged commit a32f7bd into ITISFoundation:master Aug 28, 2024
51 checks passed
This was referenced Sep 4, 2024
Closed
Closed
@odeimaiz odeimaiz mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@GitHK GitHK Awaiting requested review from GitHK

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) UX_improvements UX Feedback during frontend testing process
Projects
None yet
Milestone
Eisbock
5 participants
@odeimaiz @jsaq007 @pcrespov @sanderegg @matusdrobuliak66