Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨Autoscaling: chunk prepulled image AWS EC2 tags #6232

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 26, 2024

What do these changes do?

during early testing, this was identified as a problem. AWS EC2 Tags take a maximum of 256 characters. When pre pulling images in buffer EC2, a tag with the pre-pulled images is set on the instance for fast retrieval.
Since the list of pre pulled images can be quite long now this is chunked.

driving tests:

services/autoscaling/tests/unit/test_utils_buffer_machines_pool_core.py

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:autoscaling autoscaling service in simcore's stack label Aug 26, 2024
@sanderegg sanderegg added this to the Eisbock milestone Aug 26, 2024
@sanderegg sanderegg self-assigned this Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.7%. Comparing base (cafbf96) to head (70f399f).
Report is 471 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6232      +/-   ##
=========================================
+ Coverage    84.5%   88.7%    +4.1%     
=========================================
  Files          10    1040    +1030     
  Lines         214   46529   +46315     
  Branches       25     406     +381     
=========================================
+ Hits          181   41298   +41117     
- Misses         23    5161    +5138     
- Partials       10      70      +60     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 86.1% <100.0%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ackages/aws-library/src/aws_library/ec2/_models.py 89.4% <100.0%> (ø)
...aling/src/simcore_service_autoscaling/constants.py 100.0% <100.0%> (ø)
...e_autoscaling/modules/buffer_machines_pool_core.py 90.3% <100.0%> (ø)
...ice_autoscaling/utils/buffer_machines_pool_core.py 100.0% <100.0%> (ø)

... and 1031 files with indirect coverage changes

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for such a careful work!

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, lgtm

@sanderegg sanderegg force-pushed the autoscaling/chunk-prepulled-images branch from 592d80d to cfc8982 Compare August 26, 2024 14:05
@sanderegg sanderegg force-pushed the autoscaling/chunk-prepulled-images branch from cfc8982 to 70f399f Compare August 26, 2024 15:17
Copy link

sonarqubecloud bot commented Aug 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sanderegg sanderegg merged commit 8cfffaa into ITISFoundation:master Aug 26, 2024
56 checks passed
@sanderegg sanderegg deleted the autoscaling/chunk-prepulled-images branch August 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:autoscaling autoscaling service in simcore's stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoscaling: AWS EC2 tag value cannot exceed 256 characters: issue with keepeing pre-pulled images
6 participants