-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨Autoscaling: chunk prepulled image AWS EC2 tags #6232
🎨Autoscaling: chunk prepulled image AWS EC2 tags #6232
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6232 +/- ##
=========================================
+ Coverage 84.5% 88.7% +4.1%
=========================================
Files 10 1040 +1030
Lines 214 46529 +46315
Branches 25 406 +381
=========================================
+ Hits 181 41298 +41117
- Misses 23 5161 +5138
- Partials 10 70 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
df185c7
to
3d8c2ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks!
services/autoscaling/src/simcore_service_autoscaling/utils/buffer_machines_pool_core.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for such a careful work!
services/autoscaling/src/simcore_service_autoscaling/utils/buffer_machines_pool_core.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, lgtm
592d80d
to
cfc8982
Compare
cfc8982
to
70f399f
Compare
Quality Gate passedIssues Measures |
What do these changes do?
during early testing, this was identified as a problem. AWS EC2 Tags take a maximum of 256 characters. When pre pulling images in buffer EC2, a tag with the pre-pulled images is set on the instance for fast retrieval.
Since the list of pre pulled images can be quite long now this is chunked.
driving tests:
services/autoscaling/tests/unit/test_utils_buffer_machines_pool_core.py
Related issue/s
How to test
Dev-ops checklist