-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Autoscaling: add buffer metrics #6260
✨Autoscaling: add buffer metrics #6260
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6260 +/- ##
=========================================
+ Coverage 84.5% 88.7% +4.1%
=========================================
Files 10 1045 +1035
Lines 214 46592 +46378
Branches 25 406 +381
=========================================
+ Hits 181 41352 +41171
- Misses 23 5170 +5147
- Partials 10 70 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f3fceff
to
f39a17b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some minor comment but looks very nice and fancy thx
services/autoscaling/src/simcore_service_autoscaling/modules/buffer_machines_pool_task.py
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/buffer_machines_pool_core.py
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/instrumentation/_utils.py
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/instrumentation/_ec2_client.py
Show resolved
Hide resolved
005b8e5
to
6c50edc
Compare
6c50edc
to
4292377
Compare
Quality Gate passedIssues Measures |
What do these changes do?
This adds metrics for the buffer pooling:
For example:
--> Next step will be adding these in the grafana dashboard
bonus:
Related issue/s
How to test
Dev-ops checklist