Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Traefik: partially revert changes #6270

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 29, 2024

What do these changes do?

partially reverts #6257 which made the CORS error appear.
Also the 502 catch all was broken.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Aug 29, 2024
@sanderegg sanderegg added this to the Eisbock milestone Aug 29, 2024
@sanderegg sanderegg self-assigned this Aug 29, 2024
@sanderegg sanderegg requested a review from odeimaiz August 29, 2024 14:41
Copy link

@sanderegg sanderegg merged commit aead556 into ITISFoundation:master Aug 29, 2024
33 of 36 checks passed
@sanderegg sanderegg deleted the bugfix/CORS-traefikv3 branch August 29, 2024 14:42
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.7%. Comparing base (cafbf96) to head (3c0c569).
Report is 482 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6270      +/-   ##
=========================================
+ Coverage    84.5%   86.7%    +2.1%     
=========================================
  Files          10    1312    +1302     
  Lines         214   54643   +54429     
  Branches       25    1398    +1373     
=========================================
+ Hits          181   47384   +47203     
- Misses         23    7057    +7034     
- Partials       10     202     +192     
Flag Coverage Δ
integrationtests 64.9% <ø> (?)
unittests 84.3% <ø> (-0.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ules/dynamic_sidecar/docker_service_specs/proxy.py 100.0% <ø> (ø)

... and 1261 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant