🐛 More than 1 input port containing files can be safely pulled

[GitHK]

What do these changes do?

This issue was simple to reproduce, but we never had a good report. This was a nightmare for so many people reporting missing files in their inputs.

If input ports contain more than one port with files, these would get downloaded two at a time.
What happened? threading.get_ident() would return a unique id for the given thread. Too bad that this ID can be reassigned. To avoid future issues uuid4 replaced it.

It is now possible to pull 10 ports with each containing a 1GB file without any issue. It now works reliably every time.

Before this, almost always you would have issues when pulling 5 ports with a 1GB file in each port.

Related issue/s

• fixes Urgent bug - download of multiple inputs fails #6276

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.6%. Comparing base (cafbf96) to head (8b1b968).
Report is 494 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6286      +/-   ##
=========================================
+ Coverage    84.5%   88.6%    +4.0%     
=========================================
  Files          10    1028    +1018     
  Lines         214   45865   +45651     
  Branches       25     260     +235     
=========================================
+ Hits          181   40667   +40486     
- Misses         23    5140    +5117     
- Partials       10      58      +48     

Flag	Coverage Δ
integrationtests	64.8% <90.0%> (?)
unittests	85.9% <100.0%> (+1.4%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../simcore_sdk/node_ports_common/data_items_utils.py	100.0% <100.0%> (ø)
...re-sdk/src/simcore_sdk/node_ports_v2/port_utils.py	69.0% <100.0%> (ø)

... and 1036 files with indirect coverage changes

[sanderegg]

Try to use pytest mocker spy: https://pytest-mock.readthedocs.io/en/latest/usage.html#spy

This would allow to not have weird constants that are linked to other worldly defined fixtures..

[sanderegg]

discussed. waiting for changes. thanks!

[pcrespov]

Thx.
Could you please add a small note to stress that we are not creating the folder but just generating a random path name?

[sanderegg]

thanks for the changes. just a few small things. thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud