-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β¨ webapi: new descriptionUI
flag to render service a single page UI ποΈ
#6290
β¨ webapi: new descriptionUI
flag to render service a single page UI ποΈ
#6290
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## master #6290 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1477 +1467
Lines 214 61114 +60900
Branches 25 2063 +2038
=========================================
+ Hits 181 53873 +53692
- Misses 23 6926 +6903
- Partials 10 315 +305
Flags with carried forward coverage won't be shown. Click here to find out more.
|
descriptionUI
flag to render service a single page UI
descriptionUI
flag to render service a single page UIdescriptionUI
flag to render service a single page UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. a few thoughts
packages/models-library/src/models_library/services_metadata_editable.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/services.py
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/db/repositories/_services_sql.py
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
descriptionUI
flag to render service a single page UIdescriptionUI
flag to render service a single page UI ποΈ
What do these changes do?
A new flag
descriptionUi
(in web-api response v0.42.0 β v0.43.0) ordescription_ui
(in pg table) on the service meta-data that determines how thedescription
markdown is rendered in the UI (i.e. the service tiles). Specifically, it indicates whether thedescription
should be presented as a single web page (=true) or in another structured format (default=false). This field is primarily used by the front-end of the application to decide on the presentation style of the service's metadata.Highlights
description_ui
in pg databaseget
and input parameter forupdate
operations incatalog
rpc-apiGET
and body ofPATCH
forwebserver
rest-api (v0.42.0 β v0.43.0)Related issue/s
How to test
in place
Dev-ops checklist