Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Computational backend: if a pipeline raises, it should not prevent handling of other pipelines #6295

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 3, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Sep 3, 2024
@sanderegg sanderegg added this to the Eisbock milestone Sep 3, 2024
@sanderegg sanderegg self-assigned this Sep 3, 2024
@sanderegg sanderegg marked this pull request as ready for review September 3, 2024 15:16
Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.4%. Comparing base (cafbf96) to head (1184310).
Report is 497 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6295      +/-   ##
=========================================
- Coverage    84.5%   68.4%   -16.2%     
=========================================
  Files          10     577     +567     
  Lines         214   29444   +29230     
  Branches       25     260     +235     
=========================================
+ Hits          181   20159   +19978     
- Misses         23    9225    +9202     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.8% <100.0%> (?)
unittests 84.5% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rector_v2/modules/comp_scheduler/base_scheduler.py 86.2% <100.0%> (ø)

... and 586 files with indirect coverage changes

@sanderegg sanderegg merged commit a33fee8 into ITISFoundation:master Sep 3, 2024
54 checks passed
@sanderegg sanderegg deleted the comp-backend/ensure-a-broken-pipelin-does-not-break-all-the-others branch September 3, 2024 15:35
sanderegg added a commit that referenced this pull request Sep 3, 2024
@sanderegg sanderegg mentioned this pull request Sep 3, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Computational scheduler: 1 failing pipeline breaks the whole scheduler
2 participants