Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Autoscaling: Buffer pools metrics always showing 0 #6314

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 5, 2024

What do these changes do?

The metrics values for the autoscaling EBS buffers were always showing 0.

This PR fixes this issue as the Gauge used were overriden due to multiple instance types. Using a flat list fixes this.

related dashboard:
image

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:autoscaling autoscaling service in simcore's stack label Sep 5, 2024
@sanderegg sanderegg added this to the Eisbock milestone Sep 5, 2024
@sanderegg sanderegg self-assigned this Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.6%. Comparing base (cafbf96) to head (826707d).
Report is 510 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6314      +/-   ##
=========================================
- Coverage    84.5%   66.6%   -18.0%     
=========================================
  Files          10     626     +616     
  Lines         214   32163   +31949     
  Branches       25     260     +235     
=========================================
+ Hits          181   21438   +21257     
- Misses         23   10665   +10642     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.6% <ø> (?)
unittests 96.3% <100.0%> (+11.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...oscaling/src/simcore_service_autoscaling/models.py 100.0% <100.0%> (ø)
...ice_autoscaling/modules/instrumentation/_models.py 100.0% <100.0%> (ø)

... and 634 files with indirect coverage changes

@sanderegg sanderegg force-pushed the autoscaling/fix-buffer-pool-metrics branch from 0baf48e to 826707d Compare September 5, 2024 19:24
Copy link

sonarqubecloud bot commented Sep 5, 2024

@sanderegg sanderegg merged commit b7098eb into ITISFoundation:master Sep 6, 2024
57 checks passed
@sanderegg sanderegg deleted the autoscaling/fix-buffer-pool-metrics branch September 6, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:autoscaling autoscaling service in simcore's stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants