Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ upgrades gunicorn dependencies in webserver #6336

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

pcrespov
Copy link
Member

What do these changes do?

In master deploy webserver cannot start in one of the nodes and we speculate that it is due to guvicorn and how it uses memory. This PR upgrades gunicorn

# name before after upgrade count packages
1 gunicorn 20.1.0 23.0.0 MAJOR 1 web⬆️
2 packaging 23.1 24.1 MAJOR 3 web⬆️🧪🔧
3 setproctitle 1.2.3 1.3.3 minor 1 web⬆️
4 tomli 2.0.1 🗑️ removed 2 web🧪🔧

Related issue/s

  • in master deploy webserver cannot start in one of the nodes and we speculate that it is due to guvicorn and how it uses memory

How to test

in place

Dev-ops checklist

None

@pcrespov pcrespov self-assigned this Sep 10, 2024
@pcrespov pcrespov added a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels Sep 10, 2024
@pcrespov pcrespov added this to the Eisbock milestone Sep 10, 2024
Copy link

@pcrespov pcrespov marked this pull request as ready for review September 10, 2024 09:53
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was fast 👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov enabled auto-merge (squash) September 10, 2024 09:58
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.4%. Comparing base (cafbf96) to head (62f525b).
Report is 518 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6336      +/-   ##
=========================================
+ Coverage    84.5%   89.4%    +4.8%     
=========================================
  Files          10     361     +351     
  Lines         214   18043   +17829     
  Branches       25       0      -25     
=========================================
+ Hits          181   16136   +15955     
- Misses         23    1907    +1884     
+ Partials       10       0      -10     
Flag Coverage Δ
integrationtests 59.4% <ø> (?)
unittests 87.9% <ø> (+3.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 371 files with indirect coverage changes

@GitHK GitHK changed the title ⬆️ upgrades guvicorn dependencies in webserver ⬆️ upgrades gunicorn dependencies in webserver Sep 10, 2024
@pcrespov pcrespov merged commit e28d3bd into ITISFoundation:master Sep 10, 2024
56 checks passed
@pcrespov pcrespov deleted the mai/upgrade-webserver branch September 10, 2024 10:21
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants