Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Make the Light Theme less white #6681

Merged
merged 22 commits into from
Nov 12, 2024
Merged

🎨 [Frontend] Make the Light Theme less white #6681

merged 22 commits into from
Nov 12, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 6, 2024 •
edited
Loading

What do these changes do?

In an attempt to make the light theme more appealing, this PR reduces the number of elements that use the white color as background.

Before:
Before

After:
After

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 6, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Nov 6, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 6, 2024
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Make the Light Theme less light 🎨 [Frontend] Make the Light Theme less white Nov 11, 2024
@odeimaiz odeimaiz marked this pull request as ready for review November 11, 2024 15:28
pcrespov
pcrespov reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞 😎

@odeimaiz odeimaiz enabled auto-merge (squash) November 11, 2024 15:30
GitHK
GitHK reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz requested a review from sanderegg November 11, 2024 15:34
sanderegg
sanderegg reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jsaq007
jsaq007 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz odeimaiz merged commit 819df89 into ITISFoundation:master Nov 12, 2024
51 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 26, 2024
Closed
18 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @jsaq007 @GitHK @pcrespov @sanderegg @matusdrobuliak66