Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken cMIS export when service description was missing #6748

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 18, 2024

What do these changes do?

When Service description is missing the export would fail.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Nov 18, 2024
@GitHK GitHK added bug buggy, it does not work as expected t:maintenance Some planned maintenance work labels Nov 18, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 18, 2024
@GitHK GitHK marked this pull request as ready for review November 18, 2024 12:59
@GitHK GitHK requested a review from giancarloromeo November 18, 2024 12:59
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (050b3e6) to head (ad27cb7).

❗ There is a different number of reports uploaded between BASE (050b3e6) and HEAD (ad27cb7). Click for more details.

HEAD has 27 uploads less than BASE
Flag BASE (050b3e6) HEAD (ad27cb7)
unittests 31 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6748      +/-   ##
==========================================
- Coverage   88.51%   82.17%   -6.34%     
==========================================
  Files        1549      616     -933     
  Lines       62410    31065   -31345     
  Branches     2125      265    -1860     
==========================================
- Hits        55242    25529   -29713     
+ Misses       6841     5475    -1366     
+ Partials      327       61     -266     
Flag Coverage Δ
integrationtests 64.85% <ø> (+<0.01%) ⬆️
unittests 87.24% <ø> (+0.78%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.46% <ø> (-14.46%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.82% <ø> (-29.96%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.68% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.75% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050b3e6...ad27cb7. Read the comment docs.

---- 🚨 Try these New Features:

@GitHK GitHK enabled auto-merge (squash) November 19, 2024 06:58
@GitHK GitHK merged commit 8d03d2a into ITISFoundation:master Nov 19, 2024
84 of 89 checks passed
@GitHK GitHK deleted the pr-osparc-fix-export-cmis branch November 19, 2024 07:23
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants