Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fixes unhandled access-rights exception in projects #7012

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 7, 2025

What do these changes do?

  • 🐛 Fixes unhandled access-rights exception in projects rest handlers detected in master
  • 🎨 Cleanup error messages in study dispatcher

Related issue/s

  • issue discovered in graylog of master deploy

How to test

Dev-ops

None

@pcrespov pcrespov added the a:webserver issue related to the webserver service label Jan 7, 2025
@pcrespov pcrespov self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.70%. Comparing base (81eb245) to head (e100674).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7012      +/-   ##
==========================================
- Coverage   86.92%   86.70%   -0.22%     
==========================================
  Files        1638     1280     -358     
  Lines       64620    54768    -9852     
  Branches     2041     1008    -1033     
==========================================
- Hits        56168    47488    -8680     
+ Misses       8112     7082    -1030     
+ Partials      340      198     -142     
Flag Coverage Δ
integrationtests 64.84% <39.13%> (+0.25%) ⬆️
unittests 85.43% <82.60%> (+0.18%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 73.65% <ø> (+0.05%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.40% <ø> (-0.02%) ⬇️
dynamic_scheduler 97.19% <ø> (ø)
dynamic_sidecar 89.74% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.50% <ø> (-0.12%) ⬇️
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.08% <82.60%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81eb245...e100674. Read the comment docs.

@pcrespov pcrespov force-pushed the mai/studies-dispatcher-e2eportal branch from 820332f to 8296cf4 Compare January 7, 2025 12:28
@pcrespov pcrespov added this to the Event Horizon milestone Jan 7, 2025
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jan 7, 2025
@pcrespov pcrespov marked this pull request as ready for review January 7, 2025 13:10
@pcrespov pcrespov changed the title WIP: 🐛 Mai/studies dispatcher e2eportal 🐛 fixes unhandled access-rightes exception in projects Jan 7, 2025
@pcrespov pcrespov changed the title 🐛 fixes unhandled access-rightes exception in projects 🐛 fixes unhandled access-rights exception in projects Jan 7, 2025
Copy link

sonarqubecloud bot commented Jan 7, 2025

@pcrespov pcrespov enabled auto-merge (squash) January 7, 2025 16:34
@pcrespov pcrespov merged commit 081098c into ITISFoundation:master Jan 7, 2025
101 of 103 checks passed
@pcrespov pcrespov deleted the mai/studies-dispatcher-e2eportal branch January 8, 2025 10:46
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants