Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDTensorsMetalExt] Trying to add GPU testing to M1 jenkins #1359

Merged
merged 21 commits into from
Mar 26, 2024

Conversation

kmp5VT
Copy link
Collaborator

@kmp5VT kmp5VT commented Mar 22, 2024

Description

In this PR I am making minimal changes to get Jenkins to run CI testing on the mac M1's with Metal backend. It looks like I just need to add it to Jenkins and Dylan added juliaup for us to use different versions of Julia. Currently Metal is not supported on Julia 1.6 so I am only testing with release (1.10)

Checklist:

  • Jenkins runs NDTensors unittest on the M1 mac
  • Metal Unittests pass on Jenkins

@kmp5VT kmp5VT marked this pull request as draft March 22, 2024 19:30
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (25e2bc5) to head (ed95e15).
Report is 4 commits behind head on main.

❗ Current head ed95e15 differs from pull request most recent head b3676fc. Consider uploading reports for the commit b3676fc to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1359       +/-   ##
===========================================
- Coverage   84.36%   53.45%   -30.91%     
===========================================
  Files         100       99        -1     
  Lines        8505     8452       -53     
===========================================
- Hits         7175     4518     -2657     
- Misses       1330     3934     +2604     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmp5VT kmp5VT force-pushed the kmp5/refactor/gpu_test branch from 90e0d77 to 2780cd4 Compare March 22, 2024 21:27
@mtfishman
Copy link
Member

Nice to see this already up and running, I like how the Jenkins tests are now organized, the way the test results are displayed in Jenkins now is nicer.

The Metal tests appear to be failing because resize!(::MtlArray, ::Integer) can't be found. I added that in JuliaGPU/Metal.jl#279 but it hasn't been included in a registered version of Metal.jl yet. We could using Pkg.dev("Metal") as a temporary workaround.

@mtfishman
Copy link
Member

@maleadt sorry to ping you, but could you register a new version of Metal.jl?

@mtfishman mtfishman changed the title [NDTensors][NDTensorsMetalExt] Trying to add GPU testing to M1 jenkins [NDTensorsMetalExt] Trying to add GPU testing to M1 jenkins Mar 22, 2024
@mtfishman
Copy link
Member

Note that some of the latest test failures were caused by issues introduced in #1356.

@kmp5VT kmp5VT marked this pull request as ready for review March 26, 2024 20:51
@mtfishman mtfishman merged commit b48b881 into ITensor:main Mar 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants