Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering Issues in Normalized & Diplomatic Transcriptions #94

Closed
mdalmau opened this issue Oct 14, 2020 · 5 comments
Closed

Rendering Issues in Normalized & Diplomatic Transcriptions #94

mdalmau opened this issue Oct 14, 2020 · 5 comments
Assignees
Labels
awaiting signoff Fix has been attempted and needs confirmation that it's done bug Something isn't working prod testing Issue reported during testing of the production web site

Comments

@mdalmau
Copy link
Collaborator

mdalmau commented Oct 14, 2020

Things that should be removed in the normalized transcription are not being removed (such as accidental duplications), and in the diplomatic text they aren’t being highlighted the way they are on the current site. Below are two screenshots of ALCH0063.01, 1v. Reported by Alex Wingate.

https://webapp1.dlib.indiana.edu/newton/mss/norm/ALCH00063 compared to http://possum.dlib.indiana.edu:8197/text/ALCH00063-01/

(toggle to diplomatic)

Compare screen shots below.

@mdalmau mdalmau added bug Something isn't working prod testing Issue reported during testing of the production web site labels Oct 14, 2020
@mdalmau
Copy link
Collaborator Author

mdalmau commented Oct 14, 2020

Possum Screen shot of normalized:
image004

Current site screen shot of normalized:
image004

***And note that if you mouse over or click on the on the left, nothing happens. Other teal text works fine for mousing over though.

@mdalmau
Copy link
Collaborator Author

mdalmau commented Oct 14, 2020

Possum Screen shot of diplomatic:
image006

Current site screen shot of diplomatic:
image006

@Conal-Tuohy Conal-Tuohy self-assigned this Jan 20, 2021
@Conal-Tuohy
Copy link
Collaborator

For some reason I've only just spotted this report. It seems to be still current, though?

I had a quick look at the issue, and it looks like the XSLT really only handles <sic> when embedded in a <choice>. I think this isn't normally a problem because usually if you're going to tag an error with <sic> you are typically also going to provide a correction for it.

<xsl:template match="choice/orig | choice/sic | surplus" priority="1">

It might be good to edit the XSLT template so that it matches <sic> elements even when not inside a <choice>.

However, regarding this particular <sic>, which tags a duplicated word, the more suitable TEI element is <surplus>, which the current XSLT does handle.

@tubesoft
Copy link
Collaborator

tubesoft commented Apr 20, 2021

I removed choice/ from choice/sic on line 320 of p5-to-html.xsl. It seems to work in my local environment.

@tubesoft tubesoft added the awaiting signoff Fix has been attempted and needs confirmation that it's done label Apr 26, 2021
tubesoft pushed a commit that referenced this issue May 25, 2021
@wehooper
Copy link
Collaborator

wehooper commented Jun 3, 2021

The case of accidental duplications (Newton repeats a particle word for example) in the diplomatic version not being removed from the normalized has been fixed. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting signoff Fix has been attempted and needs confirmation that it's done bug Something isn't working prod testing Issue reported during testing of the production web site
Projects
None yet
Development

No branches or pull requests

4 participants