Skip to content

Commit

Permalink
Merge pull request #110 from IamSebastianDev/main
Browse files Browse the repository at this point in the history
PR for V1.2.2 - Hotfix
  • Loading branch information
IamSebastianDev authored May 16, 2023
2 parents 3921bbd + a722cfc commit e134526
Show file tree
Hide file tree
Showing 7 changed files with 220 additions and 111 deletions.
38 changes: 38 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: bug
assignees: ''

---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

**Additional context**
Add any other context about the problem here.
26 changes: 26 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: enhancement
assignees: ''

---

## Feature Request

### Describe the feature you would like to see added:

[Please describe the feature you would like to see added and how it would improve the project.]

### Why do you believe this feature would be useful?

[Please explain why you believe this feature would be useful and how it would benefit users of the project.]

### Have you tried implementing this feature yourself, or have you seen it implemented in other projects?

[Please provide any information you have on attempts to implement this feature or similar features in other projects.]

### Additional information:

[Please provide any additional information or context that may be helpful in understanding your feature request.]
34 changes: 34 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
## Description

[Please provide a brief description of the changes you've made in this pull request.]

## Changes Made

[Please provide a detailed description of the changes you've made in this pull request. Use bullet points or numbered lists if necessary.]

## Related Issues

[Please list any related issues or pull requests.]

## Checklist

Please check off the following items by adding an `x` inside the brackets:

- [ ] I have read and followed the contributing guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests to cover my changes.
- [ ] I have run the tests and they pass.
- [ ] I have formatted my code according to the project's style guide.
- [ ] I have added any necessary dependencies to the `package.json` file.

## Performance

[Please describe any changes to performance benchmarks that you have observed or measured.]

## Accessibility

[Please describe any accessibility considerations that you have taken into account.]

## Additional Information

[Please provide any additional information that may be helpful in reviewing this pull request.]
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest', 'windows-latest', 'macos-latest']
node-version: [16.x, 18.x]
node-version: [18.x]
runs-on: ${{matrix.os}}
steps:
- uses: actions/checkout@v3
Expand All @@ -31,4 +31,4 @@ jobs:
run: yarn lint
- name: Run tests
run: yarn test


6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@
"devDependencies": {
"@commitlint/cli": "^17.3.0",
"@commitlint/config-conventional": "^17.3.0",
"@rollup/plugin-commonjs": "^24.0.0",
"@rollup/plugin-commonjs": "^25.0.0",
"@rollup/plugin-node-resolve": "^15.0.1",
"@types/node": "^18.11.9",
"@types/node": "^20.1.1",
"alex": "^11.0.0",
"ava": "^5.1.0",
"c8": "^7.12.0",
Expand All @@ -67,7 +67,7 @@
"rollup-plugin-esbuild": "^5.0.0",
"semantic-release": "^19.0.5",
"ts-node": "^10.9.1",
"typescript": "^4.9.3"
"typescript": "^5.0.4"
},
"scripts": {
"preci": "rm -rf node_modules",
Expand Down
8 changes: 6 additions & 2 deletions src/lib/Validators/isRecordLink.util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ import { ObjectId } from '../Db/ObjectId';
export const isRecordLink = (value: unknown): value is RecordLink => {
if (typeof value !== 'string') return false;

const [namespace, id] = value.split(':');
try {
const [namespace, id] = value.split(':');

return !!(namespace && id && ObjectId.is(id));
return !!(namespace && id && ObjectId.is(id));
} catch (e) {
return false;
}
};
Loading

0 comments on commit e134526

Please sign in to comment.