Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execute the pgsqlcmd with LANG=C to make sure the output is in english and we can match for '(0 rows)' in the next task #241

Merged

Conversation

johanneskastl
Copy link
Contributor

@johanneskastl johanneskastl commented Dec 7, 2023

If the LANG variable is set to anything other than english, it might be that the output does not contain (0 rows), but contains e.g. (0 Zeilen) instead (in a German settting).

Prefixing the psqslcmd with LANG=C makes sure the output is always english...

Copy link

cla-bot bot commented Dec 7, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @johanneskastl

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@johanneskastl johanneskastl force-pushed the 20231206_icingaweb2_pqsqlcmd_with_LANG branch from d1bf10f to cc8942b Compare December 7, 2023 15:06
Copy link

cla-bot bot commented Dec 7, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @johanneskastl

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

…h LANG=C to ensure the output is in english and we can match for '(0 rows)' in the next task
@johanneskastl johanneskastl force-pushed the 20231206_icingaweb2_pqsqlcmd_with_LANG branch from cc8942b to 1d0b2ac Compare December 17, 2023 16:37
Copy link

cla-bot bot commented Dec 17, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @johanneskastl

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@johanneskastl
Copy link
Contributor Author

Signed the CLA

@bobapple
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Dec 18, 2023
Copy link
Member

@mkayontour mkayontour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this looks good.

@mkayontour mkayontour merged commit 69f708b into Icinga:main Dec 22, 2023
mkayontour pushed a commit that referenced this pull request Jan 15, 2024
* fix run pqslcmd with LANG=C to ensure the output is in english and we can match for '(0 rows)' in the next task (#241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants