-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
execute the pgsqlcmd with LANG=C to make sure the output is in english and we can match for '(0 rows)' in the next task #241
Conversation
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @johanneskastl
|
d1bf10f
to
cc8942b
Compare
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @johanneskastl
|
…h LANG=C to ensure the output is in english and we can match for '(0 rows)' in the next task
cc8942b
to
1d0b2ac
Compare
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @johanneskastl
|
Signed the CLA |
@cla-bot check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this looks good.
* fix run pqslcmd with LANG=C to ensure the output is in english and we can match for '(0 rows)' in the next task (#241)
If the LANG variable is set to anything other than english, it might be that the output does not contain
(0 rows)
, but contains e.g.(0 Zeilen)
instead (in a German settting).Prefixing the psqslcmd with
LANG=C
makes sure the output is always english...