Adjusts variable lookups #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocdaniel
force-pushed
the
fix/secret-parsing
branch
from
fce7854 to
c0b47e8
Compare
mocdaniel
force-pushed
the
fix/secret-parsing
branch
from
c0b47e8 to
699e7ef
Compare
mkayontour
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, many variable lookups happen in the form of
vars['some']['nested'][variable]['value'].This can be problematic when the variable itself is another jinja-templated expression, see also #226
Instead, we should look up variables like this wherever possible:
some.nested[variable].valueThis PR adjusts all lookups which don't explicitly check the variable's existence via
is definedto the alternative syntax.