-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow macros to be a dict in service-apply-rules #2387
base: master
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau.
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @Yoda-BZH
|
verified. |
@cla-bot check |
thank you. Is there a way to run the CI against my PR ? |
any news ? |
Hi. At $DAYJOB we're depending on this change as a local patch. It would be nice to drop the patch and share the improved functionality with everybody. 🙂 |
Same as #1453, #2085 or #2446
In Service-Apply-Rules macros like
$config.property$
should be evaluated, currently the only macro that gets evaluated is$config$
also fixes #2083, fixes #2432.
This method doesn't need
toConfigString
modification.This PR contains tests against this modification.