Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow macros to be a dict in service-apply-rules #2387

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Yoda-BZH
Copy link

@Yoda-BZH Yoda-BZH commented Sep 8, 2021

Same as #1453, #2085 or #2446

In Service-Apply-Rules macros like $config.property$ should be evaluated, currently the only macro that gets evaluated is $config$

also fixes #2083, fixes #2432.

This method doesn't need toConfigString modification.

This PR contains tests against this modification.

@cla-bot
Copy link

cla-bot bot commented Sep 8, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Sep 8, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Sep 8, 2021

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @Yoda-BZH

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@Yoda-BZH
Copy link
Author

Yoda-BZH commented Sep 8, 2021

verified.

@bobapple
Copy link
Member

bobapple commented Sep 8, 2021

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Sep 8, 2021
@Yoda-BZH
Copy link
Author

Yoda-BZH commented Sep 9, 2021

thank you.

Is there a way to run the CI against my PR ?

@Yoda-BZH
Copy link
Author

any news ?

@jcourreges
Copy link

Hi. At $DAYJOB we're depending on this change as a local patch. It would be nice to drop the patch and share the improved functionality with everybody. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants