Track changes made in dashlet views #4755
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rl when autosubmitting
I'm not yet convinced about this solution. The name *framework parameter* isn't always correct. (i.e. page) Then there's also an alternative available by using the `rel` attribute of anchors with a custom value. If it's set our JS preserves (or doesn't) the `_dashlet` param. It cannot do that for every url that's loaded into the same container. (e.g. stat badges in the footer of lists)
* It's bound to the `Window` object * If there's a request header, it's set * If there's a request param, it's set * It's preserved trough redirects not changing the path * If no redirect happens, a response header is set * JS accepts the response header always, maintains a data-attribute * JS transmits it in a request header, if it's not GET and not changing the path
* Does not signal the change yet * Does not allow to save the change yet * Too verbose code still, probably * Error handling not final
If a view is refreshed, this ensures that the scroll position doesn't change now.
yhabteab
force-pushed
the
enhanced-dashboards-development
branch
4 times, most recently
from
2c7449d to
092bbaf
Compare
yhabteab
force-pushed
the
enhanced-dashboards-development
branch
4 times, most recently
from
f29673b to
d826647
Compare
yhabteab
force-pushed
the
enhanced-dashboards-development
branch
from
010acc9 to
f5c8fc9
Compare
raviks789
force-pushed
the
enhanced-dashboards-development
branch
2 times, most recently
from
e362ae6 to
faf7709
Compare
yhabteab
force-pushed
the
enhanced-dashboards-development
branch
3 times, most recently
from
71bba87 to
9377848
Compare
yhabteab
force-pushed
the
enhanced-dashboards-development
branch
from
9377848 to
3ecf705
Compare
yhabteab
force-pushed
the
enhanced-dashboards-development
branch
2 times, most recently
from
2ef9854 to
17752eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires Icinga/ipl-web#76