MultiSelectElement: Move isValid() code to method validate()

Parent method `isValid()` calls the `validate()` method
Icinga · Jul 15, 2022 · 7dd0883 · 7dd0883
1 parent 5ffe5ef
commit 7dd0883
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/src/FormElement/MultiSelectElement.php b/src/FormElement/MultiSelectElement.php
@@ -39,21 +39,14 @@ public function setValue($value)
         return $this;
     }
 
-    public function isValid()
+    public function validate()
     {
-        if ($this->valid === null) {
-            if ($this->isRequired() && empty($this->getValue())) {
-                return false;
-            }
+        if ($this->isRequired() && empty($this->getValue())) {
+            $this->valid = false;
 
-            $this->validate();
+            return $this;
         }
 
-        return $this->valid;
-    }
-
-    public function validate()
-    {
         foreach ($this->getValue() as $value) {
             $option = $this->getOption($value);
             if (! $option || $option->getAttributes()->has('disabled')) {