Don't cache element validation state #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
force-pushed
the
do-not-cache-element-validation-state
branch
from
e50e249 to
9f2b9a6
Compare
nilmerg
requested changes
Dec 6, 2022
|
And please open PRs for reporting and jira regarding this change. |
nilmerg
reviewed
Dec 6, 2022
yhabteab
force-pushed
the
do-not-cache-element-validation-state
branch
from
9f2b9a6 to
ab433a9
Compare
nilmerg
approved these changes
Dec 12, 2022
nilmerg
added a commit
to Icinga/ipl-validator
that referenced
this pull request
Dec 15, 2022
Since Icinga/ipl-html#97 form elements don't cache the validation results anymore. This isn't a problem for most validators. Though, custom callbacks written before this change were written with the cache in mind. This change allows to control this when creating the validator. It caches by default for historical reasons. (To not break compatibility)
nilmerg
added a commit
to Icinga/ipl-validator
that referenced
this pull request
Dec 15, 2022
Since Icinga/ipl-html#97 form elements don't cache the validation results anymore. This isn't a problem for most validators. Though, custom callbacks written before this change were written with the cache in mind. This change allows to control this when creating the validator. It caches by default for historical reasons. (To not break compatibility)
nilmerg
added a commit
to Icinga/ipl-validator
that referenced
this pull request
Jan 16, 2023
Since Icinga/ipl-html#97 form elements don't cache the validation results anymore. This isn't a problem for most validators. Though, custom callbacks written before this change were written with the cache in mind. This change allows to control this when creating the validator. It caches by default for historical reasons. (To not break compatibility)
nilmerg
added a commit
to Icinga/ipl-validator
that referenced
this pull request
Jan 16, 2023
Since Icinga/ipl-html#97 form elements don't cache the validation results anymore. This isn't a problem for most validators. Though, custom callbacks written before this change were written with the cache in mind. This change allows to control this when creating the validator. It caches by default for historical reasons. (To not break compatibility)
nilmerg
added a commit
to Icinga/ipl-validator
that referenced
this pull request
Jan 16, 2023
Since Icinga/ipl-html#97 form elements don't cache the validation results anymore. This isn't a problem for most validators. Though, custom callbacks written before this change were written with the cache in mind. This change allows to control this when creating the validator. It caches by default for historical reasons. (To not break compatibility)
This was referenced Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change may break some div decorators and validate methods for the following modules as they use the
hasBeenValidated(),hasBeenValidateAndIsNotValid()methods or have their own validation logic.CompatDecoratorandFlatpickrhasMessages()whether to render errors & add error class icingaweb2-module-reporting#168LegacyDecoratorhasMessages()whether to addhas-errorclass icingaweb2-module-jira#90MultiSelectelement