Support expressions in RRule format

[yhabteab]

No description provided.

[lippserd]

Please use lower case in JSON and just use start and end without complicating things.

[yhabteab]

It's not something I chose to do. However, if you want me to do that all by myself, I can do it. But then, I have to convert everything back to uppercase in fromJson before I pass it to the library. https://github.com/simshaun/recurr/blob/master/src/Recurr/Rule.php#L445-L592

[lippserd]

It's not something I chose to do. However, if you want me to do that all by myself, I can do it. But then, I have to convert everything back to uppercase in fromJson before I pass it to the library. https://github.com/simshaun/recurr/blob/master/src/Recurr/Rule.php#L445-L592

We handle start and end on our own so I don't see why we can't just serialize the following:

• freq (getFreqAsText()) for reconstructing the rule
• frequency for the original frequency
• start and end

[lippserd]

Also please move fromJson() right after the constructor fromFrequency().

[yhabteab]

We handle start and end on our own

Yes, but only for the regular frequencies which don't have INTERVAL explicit set. Everything else is passed directly to the library.

ipl-scheduler/src/RRule.php

Lines 265 to 278 in afe46d9

	if (! isset($data['INTERVAL'])) {
	$self = static::fromFrequency($data['FREQ']);
	if (isset($data['DTSTART'])) {
	$self->startAt(new DateTime($data['DTSTART']));
	}
	if (isset($data['DTEND'])) {
	$self->endAt(new DateTime($data['DTEND']));
	}
	return $self;
	}
	return new static($data);

[lippserd]

Hadn't looked closely enough at how serialization and deserialization should work. I think there is no need to do anything with microseconds since iCalendar dates only work to the second. Also, I wouldn't test serialized JSON. This is an implementation detail:

c8186ff