Str: Also return padded array in case subject is null

Icinga · Aug 8, 2023 · 0729dcc · 0729dcc
1 parent 8bd5759
commit 0729dcc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Str.php b/src/Str.php
@@ -61,7 +61,7 @@ public static function startsWith($subject, string $start, bool $caseSensitive =
     public static function symmetricSplit($subject, string $delimiter, int $limit, $default = null)
     {
         if ($subject === null) {
-            return [];
+            return array_pad([], $limit, $default);
         }
 
         return array_pad(explode($delimiter, $subject, $limit), $limit, $default);

diff --git a/tests/StrTest.php b/tests/StrTest.php
@@ -75,6 +75,11 @@ public function testSymmetricSplitForSymmetricArrayDestructuring()
         $this->assertNull($password);
     }
 
+    public function testSymmetricSplitWithEmptySubjectStillReturnsAnArrayPaddedToTheDesiredSize()
+    {
+        $this->assertSame([null, null], Str::symmetricSplit(null, ',', 2));
+    }
+
     public function testTrimSplitTrimsWhitespacesAndSplitsByCommaByDefault()
     {
         $this->assertSame(['foo', 'bar', 'baz'], Str::trimSplit(' foo ,bar  , baz  '));