Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Properties
trait is not really what I imagined for filter meta data. Meta data, by definition, only consists of additional data that is not significant to how whatever it is related to, works. So it needs to be a separate object/interface. A separate interface is also one of the flaws I'd see of theProperties
trait. When handling/defining filter meta data, I'd expect to be able to quickly identify the usages of said meta data. This doesn't work with dynamic anonymous properties.This introduces the class
ipl\Stdlib\Data
which is more of a generic container for data. (Similar to theConfigObject
of Icinga Web 2)Classes
ipl\Stdlib\Filter\Chain
andipl\Stdlib\Filter\Condition
implement a new interfaceipl\Stdlib\Filter\MetaDataProvider
.General usage: