Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str: Also return padded array in case subject is null #45

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Str: Also return padded array in case subject is null #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Str.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public static function startsWith(?string $subject, string $start, bool $caseSen
public static function symmetricSplit(?string $subject, string $delimiter, int $limit, $default = null)
{
if ($subject === null) {
return [];
return array_pad([], $limit, $default);
}

return array_pad(explode($delimiter, $subject, $limit), $limit, $default);
Expand Down
5 changes: 5 additions & 0 deletions tests/StrTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ public function testSymmetricSplitForSymmetricArrayDestructuring()
$this->assertNull($password);
}

public function testSymmetricSplitWithEmptySubjectStillReturnsAnArrayPaddedToTheDesiredSize()
{
$this->assertSame([null, null], Str::symmetricSplit(null, ',', 2));
}

public function testTrimSplitTrimsWhitespacesAndSplitsByCommaByDefault()
{
$this->assertSame(['foo', 'bar', 'baz'], Str::trimSplit(' foo ,bar , baz '));
Expand Down