Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeferredInArrayValidator #12

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Add DeferredInArrayValidator #12

merged 1 commit into from
Nov 25, 2022

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@sukhwinder33445 sukhwinder33445 self-assigned this Nov 11, 2022
@cla-bot cla-bot bot added the cla/signed label Nov 11, 2022
@sukhwinder33445 sukhwinder33445 changed the base branch from master to add-inArray-validator November 11, 2022 17:33
This was referenced Nov 11, 2022
Merged
Merged
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch from f0ae9a0 to ecae113 Compare November 14, 2022 14:12
@sukhwinder33445 sukhwinder33445 force-pushed the add-inArray-validator branch 2 times, most recently from 8f6f39f to 92e419c Compare November 14, 2022 16:19
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch 2 times, most recently from 5d2c166 to ea77788 Compare November 14, 2022 16:38
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch from ea77788 to a954df0 Compare November 14, 2022 16:43
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch from a954df0 to 15c81e4 Compare November 14, 2022 16:46
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch from 15c81e4 to 2160daf Compare November 16, 2022 11:20
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch from 2160daf to 889a316 Compare November 16, 2022 11:49
@nilmerg
Copy link
Member

nilmerg commented Nov 16, 2022

Consider making the haystack optional. It seems wrong that this implementation here needs to override setHaystack which does nothing. The base implementation of getHaystack should return an empty array if its unset. This implementation here can then override it and call the callback instead.

@sukhwinder33445 sukhwinder33445 force-pushed the add-inArray-validator branch 3 times, most recently from 2ca332d to 8540f3d Compare November 17, 2022 09:08
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch 2 times, most recently from 735446d to 539633d Compare November 17, 2022 09:47
nilmerg
nilmerg requested changes Nov 18, 2022
View reviewed changes
src/DeferredInArrayValidator.php Outdated Show resolved Hide resolved
@nilmerg nilmerg added the enhancement New feature or request label Nov 18, 2022
@sukhwinder33445 sukhwinder33445 force-pushed the add-inArray-validator branch 2 times, most recently from 5a38383 to e18d170 Compare November 18, 2022 12:18
@sukhwinder33445 sukhwinder33445 force-pushed the add-inArray-validator branch 4 times, most recently from d9f9fc9 to b9f71e8 Compare November 22, 2022 10:12
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch 4 times, most recently from f1db47f to 837cf90 Compare November 22, 2022 14:40
@sukhwinder33445 sukhwinder33445 force-pushed the add-inArray-validator branch 2 times, most recently from 0f79fb8 to 738dd8e Compare November 22, 2022 15:42
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch from 837cf90 to ec100be Compare November 22, 2022 15:47
@sukhwinder33445 sukhwinder33445 force-pushed the add-inArray-validator branch 2 times, most recently from 3983663 to 1af5c87 Compare November 23, 2022 08:32
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch from ec100be to 41e74e8 Compare November 23, 2022 09:02
nilmerg
nilmerg requested changes Nov 23, 2022
View reviewed changes
src/DeferredInArrayValidator.php Outdated Show resolved Hide resolved
src/DeferredInArrayValidator.php Outdated Show resolved Hide resolved
@sukhwinder33445 sukhwinder33445 force-pushed the add-inArray-validator branch 2 times, most recently from 3cd9849 to b9ec1ea Compare November 23, 2022 13:38
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch from 41e74e8 to f85f2a9 Compare November 23, 2022 13:49
nilmerg
nilmerg previously approved these changes Nov 23, 2022
View reviewed changes
@nilmerg nilmerg added this to the v0.5.0 milestone Nov 24, 2022
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch from f85f2a9 to 9ec53fe Compare November 24, 2022 10:18
Base automatically changed from add-inArray-validator to master November 24, 2022 12:03
@sukhwinder33445 sukhwinder33445 force-pushed the add-DeferredInArray-validator branch from 9ec53fe to 1447e1f Compare November 24, 2022 12:08
@nilmerg nilmerg merged commit 0fba1e1 into master Nov 25, 2022
@nilmerg nilmerg deleted the add-DeferredInArray-validator branch November 25, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

@lippserd lippserd Awaiting requested review from lippserd

Assignees

@sukhwinder33445 sukhwinder33445

Labels
cla/signed enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sukhwinder33445 @nilmerg