Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduleElement: Sync start time & the first recurrence of a rule #135

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

yhabteab
Copy link
Member

The rfc standard says:

The "DTSTART" property defines the first instance in the recurrence set. The "DTSTART" property value SHOULD be synchronized with the recurrence rule, if specified. The recurrence set generated with a "DTSTART" property value not synchronized with the recurrence rule is undefined.

@cla-bot cla-bot bot added the cla/signed label Apr 11, 2023
@yhabteab yhabteab added the bug Something isn't working label Apr 11, 2023
@yhabteab yhabteab self-assigned this Apr 11, 2023
@yhabteab yhabteab added this to the v0.7.1 milestone Apr 11, 2023
@yhabteab yhabteab requested a review from nilmerg April 11, 2023 07:44
@nilmerg nilmerg removed this from the v0.7.1 milestone Apr 11, 2023
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for the synchronization.

@yhabteab yhabteab force-pushed the sync-recurrence-start-time branch from f9a09aa to d3a0892 Compare April 28, 2023 09:12
@yhabteab yhabteab requested a review from nilmerg April 28, 2023 09:13
@yhabteab yhabteab force-pushed the sync-recurrence-start-time branch from d3a0892 to 41ece95 Compare April 28, 2023 09:25
@nilmerg nilmerg merged commit 6d20102 into main Apr 28, 2023
@nilmerg nilmerg deleted the sync-recurrence-start-time branch April 28, 2023 09:37
@nilmerg nilmerg added this to the v0.8.0 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants