Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering when '*' is present in the value string #148

Closed
wants to merge 1 commit into from

Conversation

raviks789
Copy link
Contributor

Treat '*' as wildcard only when it is present in starting or end position of the value string.

fixes Icinga/icingadb-web#693

@raviks789 raviks789 added the bug Something isn't working label May 17, 2023
@raviks789 raviks789 requested a review from nilmerg May 17, 2023 12:35
@raviks789 raviks789 self-assigned this May 17, 2023
@cla-bot cla-bot bot added the cla/signed label May 17, 2023
Treat '*' as wildcard only when it is present in starting or end position
of the value string.
@raviks789 raviks789 force-pushed the fix/wild-card-filtering branch from aece52b to 7ef54e4 Compare May 17, 2023 12:37
@nilmerg
Copy link
Member

nilmerg commented May 19, 2023

We cannot do it this way. A wildcard must be valid anywhere in a value.

This should be addressed in Icinga DB Web with the help of #103.

@nilmerg nilmerg closed this May 19, 2023
@nilmerg nilmerg deleted the fix/wild-card-filtering branch May 19, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A service with a literal * in the name is ignored by the multiselection detail
2 participants