Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional $defaultSort parameter for SortControl::apply method #154

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

raviks789
Copy link
Contributor

This gives an option to set the default sort of sort control other than the ipl\Orm\Models default sort as default.

@nilmerg nilmerg added this to the v0.9.0 milestone Jun 7, 2023
@nilmerg nilmerg added the enhancement New feature or request label Jun 7, 2023
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Controller class here also has a createSortControl method, please adjust it as well.

@raviks789 raviks789 force-pushed the feature/sort-control-change-default-sort branch 2 times, most recently from 272bc8b to 57a6a16 Compare June 7, 2023 08:08
src/Compat/CompatController.php Outdated Show resolved Hide resolved
This gives an option to set the default sort of sort control other than the
`ipl\Orm\Model`s default sort as default.
@raviks789 raviks789 force-pushed the feature/sort-control-change-default-sort branch from 57a6a16 to bc03270 Compare June 7, 2023 14:12
@raviks789 raviks789 requested a review from nilmerg June 7, 2023 14:12
@nilmerg nilmerg merged commit 7855ce3 into main Jun 12, 2023
@nilmerg nilmerg deleted the feature/sort-control-change-default-sort branch June 12, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants