Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completer: Fix null data being emitted when triggering instrumented e… #78

Merged
merged 1 commit into from
May 12, 2022
Merged

Completer: Fix null data being emitted when triggering instrumented e… #78

merged 1 commit into from
May 12, 2022

Conversation

yhabteab
Copy link
Member

@yhabteab yhabteab commented May 5, 2022

…vents

@cla-bot cla-bot bot added the cla/signed label May 5, 2022
@yhabteab yhabteab marked this pull request as draft May 5, 2022 14:01
@yhabteab yhabteab force-pushed the bugfix/ensure-instrumented-event-details-is-not-null branch from edfb8cc to 77a0ef1 Compare May 6, 2022 06:46
@yhabteab yhabteab marked this pull request as ready for review May 6, 2022 06:47
@yhabteab yhabteab requested a review from nilmerg May 6, 2022 06:48
@yhabteab yhabteab force-pushed the bugfix/ensure-instrumented-event-details-is-not-null branch from 77a0ef1 to a330e8c Compare May 9, 2022 07:05
@yhabteab yhabteab requested a review from nilmerg May 9, 2022 07:07
@nilmerg nilmerg merged commit 3fc5c87 into master May 12, 2022
@nilmerg nilmerg deleted the bugfix/ensure-instrumented-event-details-is-not-null branch May 12, 2022 08:19
@nilmerg nilmerg added this to the v0.5.0 milestone May 12, 2022
@nilmerg nilmerg added the bug Something isn't working label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla/signed
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabteab @nilmerg