Provide standardized control layout #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
provide-standardized-control-layout
branch
3 times, most recently
from
e0dccbc to
6c185bf
Compare
Such a container is nearly always required for a good looking layout, so why shouldn't it be there by default?
They include all layout and a bit of style rules to replicate the default control layout that is used by Icinga DB Web and various other modules.
nilmerg
force-pushed
the
provide-standardized-control-layout
branch
from
6c185bf to
e58a61e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to have the default list control layout readily available for use in other modules than Icinga DB Web where it originates from.
Some notes:
.controlswouldn't have made use of this mixin. The explicit usage of it was another negative, as it meant a hard dependency of ipl-web. (Which is bad for CSS).controlsby default and rely on the strict nature of the rules (>everywhere) that anyone not wanting them to apply could just wrap their custom controls in another container. (An opt-out version, effectively) Though, existing modules would have a problem with that, most notable the Director.PaginationControl,LimitControl,SortControlorSearchBaras control by usingCompatController::addControl()to want the default control layout. Anyone not wanting this can either add controls by usage of$this->controls->add()or by removing the classdefault-layoutafterwards. This has benefits of both previous options: It's opt-out, Existing modules having used them still have them, Existing modules not using them are still not affected, New modules wanting to use them can do so easily