Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable pwa on development #144

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

tuanphungcz
Copy link
Contributor

@tuanphungcz tuanphungcz commented Aug 6, 2021

Jira ticket

https://ideamarketio.atlassian.net/browse/IDEAMARKET-113

Summary

  • There is this warning, which is fixed by disabling pwa on development mode. For debugging purposes, we can comment out disable prop.

GoogleChrome/workbox#1790
image

@tuanphungcz tuanphungcz requested review from Bobface and Shmoji August 6, 2021 10:09
@tuanphungcz tuanphungcz self-assigned this Aug 6, 2021
@vercel
Copy link

vercel bot commented Aug 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

ideamarket-frontend – ./

🔍 Inspect: https://vercel.com/ideamarket/ideamarket-frontend/2RPnfPdGDNc2L8wgUboXBzmPwuFJ
✅ Preview: https://ideamarket-frontend-git-feat-pwa-disable-develop-ideamarket.vercel.app

ideamarket-frontend-dev – ./

🔍 Inspect: https://vercel.com/ideamarket/ideamarket-frontend-dev/64bdctK9eHWDxwi73Q8uqVAgxGh1
✅ Preview: https://ideamarket-frontend-dev-git-feat-pwa-disable-develop-ideamarket.vercel.app

ideamarket-frontend-live – ./

🔍 Inspect: https://vercel.com/ideamarket/ideamarket-frontend-live/ApiAfN7ZdQxaRiV7vAyVbLzwzepw
✅ Preview: https://ideamarket-frontend-live-git-feat-pwa-disable-919e19-ideamarket.vercel.app

@tuanphungcz tuanphungcz merged commit 2705b18 into development Aug 6, 2021
@tuanphungcz tuanphungcz deleted the feat/pwa-disable-develop branch August 6, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants