Iterate binding table using standard 'for' loop #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the use of recycle the only interpreted code reported by LuaJIT's profiler is on lwaftr.lua:
Entry
-- 4% lwaftr.lua:43
corresponds to a loop inbinding_lookup_ipv4_from_pkt
. Iterating the binding table with a standard for loop instead ofipairs
makes LuaJIT happy and after the patch all interpreted code is gone.Performance improves significantly:
I run the
end-to-end.sh
tests. All tests passed.