Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global imports and configuration rework #49

Merged
merged 5 commits into from
Feb 28, 2018
Merged

Conversation

Igmat
Copy link
Owner

@Igmat Igmat commented Feb 28, 2018

Description of Change

While working on #41, I've found that problem isn't in compiler options of typescript but in its include option which adds all global namespaces (e.g. reflect-metadata) from included files to compiler context. So solution for this issue is adding an option to include some files/modules/packages to context of each test.
This new option has shown some existing problems with baset configuration, so a little refactoring of this part also included here.

Pull Request check-list

  • Does the linter pass?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

@Igmat Igmat requested a review from almmiko February 28, 2018 11:56
@Igmat Igmat merged commit aea800b into master Feb 28, 2018
@Igmat Igmat deleted the fix/ts-helpers-import branch February 28, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant