Skip to content

Commit

Permalink
bug(*): fix orders json data, make orderdto custoemrid and shipperid …
Browse files Browse the repository at this point in the history
…nullable

bug(*): fix orders json data, make orderdto custoemrid and shipperid nullable
  • Loading branch information
ddidgdimitrov-infragistics committed Feb 12, 2025
1 parent 0560945 commit efe414b
Show file tree
Hide file tree
Showing 3 changed files with 15,774 additions and 14,944 deletions.
2 changes: 1 addition & 1 deletion NorthwindCRUD/Models/Contracts/IOrder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public interface IOrder

int EmployeeId { get; set; }

int ShipperId { get; set; }
int? ShipperId { get; set; }

string OrderDate { get; set; }

Expand Down
4 changes: 2 additions & 2 deletions NorthwindCRUD/Models/Dtos/OrderDto.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ public class OrderDto : IOrder
public int OrderId { get; set; }

[Required(ErrorMessage = "CustomerId is required.")]
public string CustomerId { get; set; }
public string? CustomerId { get; set; }

Check failure on line 12 in NorthwindCRUD/Models/Dtos/OrderDto.cs

View workflow job for this annotation

GitHub Actions / build-and-test

Nullability of reference types in return type of 'string? OrderDto.CustomerId.get' doesn't match implicitly implemented member 'string IOrder.CustomerId.get' (possibly because of nullability attributes).

Check failure on line 12 in NorthwindCRUD/Models/Dtos/OrderDto.cs

View workflow job for this annotation

GitHub Actions / build-and-test

Nullability of reference types in return type of 'string? OrderDto.CustomerId.get' doesn't match implicitly implemented member 'string IOrder.CustomerId.get' (possibly because of nullability attributes).

public int EmployeeId { get; set; }

public int ShipperId { get; set; }
public int? ShipperId { get; set; }

[DataType(DataType.Date, ErrorMessage = "OrderDate must be a valid date.")]
public string OrderDate { get; set; }
Expand Down
Loading

0 comments on commit efe414b

Please sign in to comment.