Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including optional deps in the parent and child projects #37

Open
wants to merge 1 commit into
base: vnext
Choose a base branch
from
Open

Including optional deps in the parent and child projects #37

wants to merge 1 commit into from

Conversation

turbobobbytraykov
Copy link
Contributor

Re-generate the package-lock.json files using 'npm install --include=optional' as per Damyan's recommendations

rstratkovinfrag
rstratkovinfrag requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@rstratkovinfrag rstratkovinfrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts to be fixed

@skrustev
Copy link
Member

skrustev commented Jan 24, 2025 •
edited
Loading

Can you add the include=optional to the .npmrc files? I guess some projects don't have it and will need adding with just this option.

@dkamburov
Copy link
Collaborator

@rstratkovinfrag can you take a look at the merge conflicts and comments from Svetoslav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstratkovinfrag rstratkovinfrag rstratkovinfrag requested changes

@skrustev skrustev Awaiting requested review from skrustev

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turbobobbytraykov @skrustev @dkamburov @rstratkovinfrag