[Fleet Management] Add overlay close scroll strategy #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarielaTihova
added
✅ status: verified
|
@IMinchev64 could you please resolve the conflicts |
IMinchev64
force-pushed
the
iminchev/add-scroll-strategy
branch
from
dbf2a0b to
54eefbe
Compare
mddragnev
requested changes
Feb 7, 2025
| @@ -30,6 +30,13 @@ igx-card { | |||
| border-radius: 4px; | |||
| } | |||
|
|
|||
| ::ng-deep { | |||
| igx-card .igx-card-header__thumbnail { | |||
There was a problem hiding this comment.
I added this since for some reason the igx-card-header_thumbnail has a margin-inline-end of 16px by default which would offset the avatar in the overlay:
(P.S. I have to test this separately and see if it should be logged as a bug for the igx-card)
| @@ -249,7 +249,7 @@ <h6>Utilization per Month</h6> | |||
| </igx-grid> | |||
|
|
|||
| <ng-template #tripHistory let-tripHistoryData> | |||
| <igx-grid [data]="tripHistoryData" height="100%" width="100%"> | |||
| <igx-grid [data]="tripHistoryData" height="auto" width="100%"> | |||
mddragnev
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.