Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider labels feature #4540

Merged
merged 44 commits into from
Jun 7, 2019
Merged

Slider labels feature #4540

merged 44 commits into from
Jun 7, 2019

Conversation

Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Apr 15, 2019

Closes #3449
Closes #4562
Closes #4559
Closes #2622

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

represents the slider labels by their indexes and allow templating of
the lower and upper thumbs

Closes #3449 #4492
refactoring + aria support and labels length validaiton

Closes #3449
@Aleksandyr
Copy link
Contributor Author

Aleksandyr commented Apr 15, 2019

This PR needs further updates related to the thumb labels, due providing users with ability to implement custom templates representing those labels. The main goal for exposing them was to allow users cut off the text that the label contains. As we've already discussed with @simeonoff, below are the changes that need to be added.

%igx-thumb-label {
        max-width: rem(80px);
        overflow: hidden;
}

@Aleksandyr
Copy link
Contributor Author

@simeonoff has updated the slider sample in order to show how the user can manipulate the label in order to fit the text within the thumbs.

simeonoff
simeonoff previously approved these changes Apr 15, 2019
@zdrawku
Copy link
Contributor

zdrawku commented Apr 15, 2019

@Aleksandyr update che changelog as well

@nrobakova nrobakova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 15, 2019
@nrobakova
Copy link
Contributor

I tested this PR and found some issues:

  1. When slider type is Range and move with the key board the next trump is not previewed, and if I move over it and continue navigation it does not hides
  2. When change slider type from Slider to Range, the first trump cannot be moved
  3. When remove labels for a slider, then add new with 2 items and then add again labels with 6 items the max value of the slider becomes 1

@Aleksandyr Aleksandyr added ❌ status: awaiting-test PRs awaiting manual verification refactoring ❌ do not merge and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 5, 2019
@Aleksandyr
Copy link
Contributor Author

API documentation should be updated.

@nrobakova nrobakova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 6, 2019
@nrobakova nrobakova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 6, 2019
@zdrawku zdrawku merged commit 02e645f into 7.2.x Jun 7, 2019
@zdrawku zdrawku deleted the slider-labels-feature branch June 7, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature refactoring slider version: 7.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants