Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Row Layout keyboard navigation #4757

Merged
merged 146 commits into from
Jun 5, 2019
Merged

Multi Row Layout keyboard navigation #4757

merged 146 commits into from
Jun 5, 2019

Conversation

dkamburov
Copy link
Contributor

@dkamburov dkamburov commented May 13, 2019

Closes #4708
Related #4384

TODO:

  • Automate scenarios with Tab navigation, including cell, row editing, and navigating with Ctrl
  • Fix Ctrl + Up/Down navigation
  • Fix navigation from pinned or unpinned area

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

dkamburov and others added 30 commits April 23, 2019 23:48
…vigation service runtime if column layouts are defined.
Moving mrl specific logic in its own service and setting na…
@PavlovVasil PavlovVasil added the 🛠️ status: in-development Issues and PRs with active development on them label Jun 3, 2019
@MayaKirova MayaKirova added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 4, 2019
@MayaKirova
Copy link
Contributor

@PavlovVasil Please re-test with latest changes.

@PavlovVasil PavlovVasil added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 4, 2019
@dkamburov dkamburov requested a review from ChronosSF June 4, 2019 12:42
@PavlovVasil
Copy link
Contributor

PavlovVasil commented Jun 4, 2019

@dkamburov @ChronosSF @MayaKirova @mpavlinov
The issue with "Tab" key not scrolling horizontally has been fixed. There are two more:

  1. When a cell from a pinned group gets focused, the bottom-border of the cells disappears. Running the samples repo and opening http://localhost:4200/samples/grid/grid-multi-row-layout would show you this if you select a cell in the first row:

Sketch

The dev demos look like this if you click the button and pin the "Pin/Unpin Second Group" button at the bottom:

Sketch2

  1. If Group By has been enabled:
    1. Run the samples repo and open http://localhost:4200/samples/grid/grid-multi-row-layout
    2. Collapse all groups by clicking the button at the top left
    3. Expand the first three groups as well as the last one
    4. Click the middle cell of the last grid row - "London"
    5. Hold the up arrow key in order to scroll to the top
      Result:
      When the navigation tries to scroll through the collapsed groups, it looses focus and stops working. The scroll position is not correct either, and scrolls to the bottom:

MRLCollapsedGroups

@PavlovVasil PavlovVasil added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Jun 4, 2019
@MayaKirova
Copy link
Contributor

@PavlovVasil Regarding 1). It is not an issue related to navigation, same can be reproduced in master if you select a cell range in MRL grid. Seems to be a styling issue due to an additional style that applies border-bottom: 0. Please log it separately.

@MayaKirova MayaKirova added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 5, 2019
@MayaKirova
Copy link
Contributor

@PavlovVasil Please re-test.

@PavlovVasil PavlovVasil added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jun 5, 2019
@mpavlinov mpavlinov merged commit a469ca0 into 7.3.x Jun 5, 2019
@mpavlinov mpavlinov deleted the dkamburov/mrl-nav branch June 5, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: general grid: multi-row-layout squash-merge Merge PR with "Squash and Merge" option version: 7.3.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants