Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slider ticks enhancements #6230

Merged
merged 13 commits into from
Dec 3, 2019
Merged

Slider ticks enhancements #6230

merged 13 commits into from
Dec 3, 2019

Conversation

Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Nov 29, 2019 •
edited
Loading

Closes #6228
Closes #6225

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@hanastasov hanastasov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 29, 2019
hanastasov
hanastasov previously approved these changes Nov 29, 2019
View reviewed changes
rkaraivanov
rkaraivanov requested changes Nov 29, 2019
View reviewed changes
Copy link
Member

@rkaraivanov rkaraivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the comments

kdinev
kdinev requested changes Dec 2, 2019
View reviewed changes
Copy link
Member

@kdinev kdinev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a migration to remove all isContinuous inputs from the templates.

@Aleksandyr Aleksandyr changed the title Slider ticks refactoring Slider ticks enhancements Dec 2, 2019
@zdrawku zdrawku requested a review from rkaraivanov December 3, 2019 06:14
@kdinev kdinev merged commit c268bcb into master Dec 3, 2019
@kdinev kdinev deleted the slider-ticks-refactoring branch December 3, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev approved these changes

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@hanastasov hanastasov hanastasov left review comments

Assignees

@rkaraivanov rkaraivanov

Labels
slider version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slider ticks enhancements When set to 1, secondaryTicks are not rendered
4 participants
@Aleksandyr @kdinev @hanastasov @rkaraivanov