Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitter base #6985

Merged
merged 76 commits into from
Apr 9, 2020
Merged

Splitter base #6985

merged 76 commits into from
Apr 9, 2020

Conversation

MayaKirova
Copy link
Contributor

@MayaKirova MayaKirova commented Mar 27, 2020

Related to #6639

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@ChronosSF ChronosSF added splitter 🛠️ status: in-development Issues and PRs with active development on them labels Mar 27, 2020
@radomirchev radomirchev mentioned this pull request Mar 27, 2020
8 tasks
@3phase
Copy link
Contributor

3phase commented Apr 7, 2020

After testing the keyboard navigation PR, there seemed to be a weird behavior when moving the right border of the central grid pane a little bit to the left and then using Ctrl+Left Arrow to hide the whole central pane. The second misbehavior is when focusing the left border of the central pane via Shift+Tab and clicking Ctrl+Right Arrow. The rightmost grid won't get expanded at its maximal width, instead would stay cut. My explanations are described better by the gif below.

splitter_bug_1

@simeonoff simeonoff linked an issue Apr 8, 2020 that may be closed by this pull request
@ChronosSF ChronosSF added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 9, 2020
@ChronosSF ChronosSF merged commit e036cc0 into master Apr 9, 2020
@ChronosSF ChronosSF deleted the mkirova/splitter-base branch April 9, 2020 16:37
@ChronosSF ChronosSF added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
splitter ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitter Styling
5 participants