-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grid): added export progress visualization in toolbar #8000
Conversation
@simeonoff, the export progress visualization is implemented in the grid toolbar but there is some work needed on styling. Let me know if you (or whoever is working on this) have any questions. |
projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar.component.ts
Outdated
Show resolved
Hide resolved
…dicator inside the grid toolbar.
@@ -23,6 +23,10 @@ | |||
@extend %igx-grid-toolbar__actions !optional; | |||
} | |||
|
|||
@include e(export-progress){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name this something more generic. I think it might be used for other purposes as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about e(progress-bar)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that's fine 👍
I've noticed an issue with different themes. |
…dicator inside the grid toolbar.
@desig9stein and I had a call to look at the style and decided to go along with 2px high progress that is 1px below the bottom of the toolbar in order to overlap the border and look even better. I have updated the spec. |
src/styles/igniteui-theme.scss
Outdated
@@ -19,6 +19,7 @@ body { | |||
|
|||
@include igx-core($direction: ltr); | |||
@include igx-theme($palette: $palette, $schema: $schema); | |||
@include igx-theme($palette: $palette, $schema: $schema, $legacy-support: true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't make changes to this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at my comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, you still make changes to the file. Please, just revert all changes you made to the igniteui-theme.scss file.
Closes #7738
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)