refactor(combo, select): update indigo colors #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desig9stein
reviewed
Jul 22, 2024
| @@ -151,12 +151,18 @@ $bootstrap-select: extend( | |||
|
|
|||
| /// Generates an indigo select schema. | |||
| /// @type {Map} | |||
| /// @prop {Map} toggle-button-background [trasnparent] - The select toggle button background color. | |||
| /// @prop {Map} toggle-button-background-focus [transparent] - The select toggle button background color when the select is focused. | |||
| /// @prop {Map} toggle-button-background-focus--border [color: ('gray', 300)] The select toggle button background color when the select is focused. | |||
There was a problem hiding this comment.
The value of toggle-button-background-focus--border should be transparent
| /// @prop {Map} toggle-button-foreground-disabled [color: ('gray', 300)] - The combo toggle button foreground color when the combo is disabled. | ||
| /// @prop {Color} toggle-button-background-disabled [transparent] - The combo toggle button background color when the combo is disabled. | ||
| /// @requires {Map} $light-combo | ||
| $indigo-combo: extend( | ||
| $light-combo, | ||
| ( | ||
| empty-list-placeholder-color: ( |
There was a problem hiding this comment.
empty-list-placeholder-color is not documented
| /// @prop {Map} toggle-button-background-disabled [transparent] - The combo toggle button background color when the combo is disabled. | ||
| /// @prop {Map} toggle-button-foreground [color: ('gray', 700)] - The combo toggle button foreground color. | ||
| /// @prop {Map} toggle-button-foreground-focus [color: ('gray', 700)] - The combo toggle button foreground color when the combo is focused. | ||
| /// @prop {Map} toggle-button-foreground-filled [color: ('gray', 900)] - The combo toggle button foreground color when the combo is focused. |
There was a problem hiding this comment.
toggle-button-foreground,
toggle-button-foreground-focus,
toggle-button-foreground-filled
Those are not used in this schema, you can remove them
|
@desig9stein can you do a second round of reviews, please? |
desig9stein
added
💥 status: in-test
desig9stein
approved these changes
Jul 29, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
… Select (#310) * refactor(json): don't log out a comment with no context (#217) * Indigo: Add grid-related updates (#303) * refactor(combo, select): update indigo colors (#305) * calendar - update light and dark schemas according to new design (#300) * calendar - fix indigo colors for light and dark schemas (#320) * refactor(combo, select): update indigo color props * indigo calendar fixes (#321) * fix(calendar): fix indigo schema colors (#322) * refactor(grid): update indigo colors (#323) * refactor(combo): update clear icon colors for dark indigo * Update indigo grid schemas (#331) * refactor(grid): update schema colors * refactor(grid): make sure that row odd and event text color inherit their value from content-text-color make sure that content-text-color is set to gra 900 * feat(grid): update schema colors * feat(grid): update schema colors * fix(grid): remove content-text-color form indigo schema since it has to be gray 800 in light theme. * fix(grid): Update indigo schema colors * refactor(grid): fix row drag bg colors --------- Co-authored-by: Marin Popov <[email protected]> Co-authored-by: desig9stein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #302
Closes #301