Preserve property read side effects during tree shaking #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve property read side effects during tree shaking.
With default tsdx settings, tree shaking assumes that there will be no side effects for object reads. This currently breaks firestorter functionality when the sync mode is set to 'Auto', which is the recommended setting. Specifically, the following lines are removed from the compiled js:
You can inspect
firestorter.cjs.development.js
to see it clearly.This implies that observing (via mobx) these getters (i.e.
isLoaded
) will not have the intended effect of tracking that observable reference, and fetching data from the Firestore collection.