Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Dockerfile to use multi-stage build #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update Dockerfile to use multi-stage build #79

wants to merge 1 commit into from

Conversation

rasoro
Copy link
Member

@rasoro rasoro commented Oct 27, 2021

Before
courier-before

After
courier-after

@codecov-commenter
Copy link

Codecov Report

Merging #79 (e97c0d1) into main (8d70f22) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   71.51%   71.51%           
=======================================
  Files          95       95           
  Lines        8444     8444           
=======================================
  Hits         6039     6039           
  Misses       1788     1788           
  Partials      617      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d70f22...e97c0d1. Read the comment docs.

matmsa27
matmsa27 reviewed Oct 28, 2021
View reviewed changes
docker/Dockerfile

EXPOSE 8080
ENTRYPOINT ["courier"]
ENTRYPOINT ["./courier"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing endline here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matmsa27 matmsa27 matmsa27 left review comments

@baltazarweni baltazarweni baltazarweni approved these changes

@jcbalmeida jcbalmeida Awaiting requested review from jcbalmeida

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rasoro @codecov-commenter @matmsa27 @baltazarweni