Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KKPE] Parenting bug again #109

Open
gievepix opened this issue Dec 30, 2024 · 5 comments
Open

[KKPE] Parenting bug again #109

gievepix opened this issue Dec 30, 2024 · 5 comments

Comments

@gievepix
Copy link

gievepix commented Dec 30, 2024

Seems like bug described in #58 is back in KKPE 2.18.1, except the way to reproduce it is different and even more simple (so it's easier to trigger accidentally/harder to avoid):

  1. add character to scene
  2. add any object (actual object or folder)
  3. parent this object to any part of character
  4. delete it -> parenting breaks after that

Parenting breaks completely regardless of whether it's related to any character or not, until scene reset or deleting character that triggered this bug which seemingly "fixes" it.

@ManlyMarco
Copy link
Contributor

Can you post the output_log?

@gievepix
Copy link
Author

Well, I wanted to attach the log to original post, but thought it should be easy enough to reproduce. Anyway, here it is:
output_log.txt

@ManlyMarco
Copy link
Contributor

@ReafLife The crash is in RefreshSkinnedMeshRendererList, looks changes in one of your PRs caused it.

ReafLife added a commit to ReafLife/HSPlugins that referenced this issue Jan 3, 2025
@ReafLife
Copy link
Contributor

ReafLife commented Jan 3, 2025

76e5243
Commit to fix this issue has been performed

@DeadMansChest
Copy link

DeadMansChest commented Jan 21, 2025

Still getting this issue as of r2.15; same activation conditions as OP

Stack trace:
HSPE.AMModules.BlendShapesEditor+<>c__DisplayClass90_0.<RefreshSkinnedMeshRendererList>b__0 (UnityEngine.GameObject child) (at <a3149f5141d444f1b6b92d7e110a363f>:0)
System.Linq.Enumerable.All[TSource] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] predicate) (at <fbb5ed17eb6e46c680000f8910ebb50c>:0)
HSPE.AMModules.BlendShapesEditor.RefreshSkinnedMeshRendererList () (at <a3149f5141d444f1b6b92d7e110a363f>:0)
HSPE.AMModules.BlendShapesEditor.OnParentage (Studio.TreeNodeObject parent, Studio.TreeNodeObject child) (at <a3149f5141d444f1b6b92d7e110a363f>:0)
HSPE.PoseController.OnParentage (Studio.TreeNodeObject parent, Studio.TreeNodeObject child) (at <a3149f5141d444f1b6b92d7e110a363f>:0)
HSPE.PoseController.OnParentageRoot (Studio.TreeNodeObject parent, Studio.TreeNodeObject child) (at <a3149f5141d444f1b6b92d7e110a363f>:0)
Studio.TreeNodeCtrl.SetParent (Studio.TreeNodeObject _node, Studio.TreeNodeObject _parent) (at <f42641e4193742afa1c79de0438b6fed>:0)
Studio.TreeNodeCtrl.SetParent () (at <f42641e4193742afa1c79de0438b6fed>:0)
(wrapper dynamic-method) Studio.WorkspaceCtrl.DMD<Studio.WorkspaceCtrl::OnClickParent>(Studio.WorkspaceCtrl)
UnityEngine.Events.InvokableCall.Invoke () (at <a43c47796b1b4dc78509dc74aec2356b>:0)
UnityEngine.Events.UnityEvent.Invoke () (at <a43c47796b1b4dc78509dc74aec2356b>:0)
UnityEngine.UI.Button.Press () (at <f0cd79bc997b4fdfbb94781bafee7971>:0)
UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at <f0cd79bc997b4fdfbb94781bafee7971>:0)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <f0cd79bc997b4fdfbb94781bafee7971>:0)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at <f0cd79bc997b4fdfbb94781bafee7971>:0)
UnityEngine.EventSystems.EventSystem:Update()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants