Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDC ENH: 2 servers #141

Open
wants to merge 74 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
6ba2ec9
IDC ENH: 2 servers fetching
Punzo May 10, 2022
7aa7a7d
fix conflicts
Punzo May 12, 2022
78acc03
minor fixes
Punzo May 13, 2022
ee2fc3d
fix conflicts
Punzo May 13, 2022
4575fec
update
Punzo Jun 17, 2022
6e74a92
Merge branch 'master' of https://github.com/OHIF/Viewers into IDC2ser…
Punzo Jun 17, 2022
ce0afdd
update
Punzo Jun 17, 2022
3b6727d
update to OHIF 4.12.26 and add on thumbnail origin server
Punzo Jun 17, 2022
11fc119
update
Punzo Jun 17, 2022
863d5cb
fix caching and seg server pointing
Punzo Jun 20, 2022
4eea84b
Add fork name in thhe app name in debug report window
Punzo Jun 27, 2022
69639c1
Merge branch 'master' of https://github.com/OHIF/Viewers into IDC2ser…
Punzo Jun 28, 2022
8c441b1
Update to OHIFv4.12.28
Punzo Jun 28, 2022
4cf3a0b
Merge branch 'master' of https://github.com/OHIF/Viewers into IDC2ser…
Punzo Jun 29, 2022
207efd1
Merge branch 'master' of https://github.com/ImagingDataCommons/Viewer…
Punzo Jun 30, 2022
595eee7
Update to OHIFv 4.12.30
Punzo Jun 30, 2022
353c180
Re #149: remove firebase files
Punzo Aug 24, 2022
e830eee
Re #149: remove firebase files
Punzo Aug 24, 2022
927b602
Re #149: remove firebase files
Punzo Aug 24, 2022
fffe05d
Merge pull request #151 from ImagingDataCommons/master
Punzo Aug 24, 2022
505b7d6
update IDC server release
Punzo Aug 25, 2022
e0638a1
disable study list
Punzo Aug 25, 2022
60f6f41
Merge pull request #153 from ImagingDataCommons/master
Punzo Aug 25, 2022
ef60156
Fix minor issues IDC (#2903)
Punzo Aug 31, 2022
fe9551b
chore(release): publish [skip ci]
ohif-bot Aug 31, 2022
3ca720d
Merge pull request #155 from OHIF/master
Punzo Aug 31, 2022
a6338ea
Re IDC #2869: update dcmjs for fixing eps in nearly equal condition …
Punzo Sep 1, 2022
d292108
chore(release): publish [skip ci]
ohif-bot Sep 1, 2022
d6a1301
Merge pull request #157 from OHIF/master
Punzo Sep 1, 2022
aaab6d2
Re IDC #2849: raise error if dicom request is not conforming with the…
Punzo Sep 2, 2022
ddfde92
chore(release): publish [skip ci]
ohif-bot Sep 2, 2022
94981a5
Merge pull request #159 from OHIF/master
Punzo Sep 2, 2022
d74ad37
fix: hotkey page up/down did not work (#2910)
horner Sep 8, 2022
80dfdcc
chore(release): publish [skip ci]
ohif-bot Sep 8, 2022
47a6130
Re IDC #2919: fix popup notifications behavior (#2923)
Punzo Sep 12, 2022
ebbc9e0
chore(release): publish [skip ci]
ohif-bot Sep 12, 2022
e0fb439
Fix IDC Re #2918: Runtime tolerance for SEGs loading (#2924)
Punzo Sep 12, 2022
4546ede
chore(release): publish [skip ci]
ohif-bot Sep 12, 2022
8ff0c40
Merge pull request #162 from OHIF/master
Punzo Sep 12, 2022
e2f4f95
Re IDC #2935: fix parsing of Instance-level qualitative annotations (…
Punzo Sep 19, 2022
c5ee092
chore(release): publish [skip ci]
ohif-bot Sep 19, 2022
67598a3
Merge pull request #164 from OHIF/master
Punzo Sep 19, 2022
eb7eb56
Re IDC #2934: update cornerstoneWADOImageLoader to v 4.2.1 (#2944)
Punzo Sep 20, 2022
d7e1d2c
chore(release): publish [skip ci]
ohif-bot Sep 20, 2022
7866041
Merge pull request #167 from OHIF/master
Punzo Sep 20, 2022
c5ebeaa
Re IDC #2847: Fix 2d MPR rendering issue for the sagittal view (#2960)
GitanjaliChhetri Sep 26, 2022
7aba01f
chore(release): publish [skip ci]
ohif-bot Sep 26, 2022
713f2d8
Merge pull request #169 from OHIF/master
Punzo Sep 26, 2022
f7db74a
fix: 2965 Correct Parsing Logic for Qualitative Instance Level SR (#2…
GitanjaliChhetri Oct 25, 2022
eaa423c
chore(release): publish [skip ci]
ohif-bot Oct 25, 2022
545161d
fix: #2964 Update message for segmentation error loading due to orien…
GitanjaliChhetri Oct 28, 2022
0f89aa3
chore(release): publish [skip ci]
ohif-bot Oct 28, 2022
0b8facb
remove-unsed-code-from-SR-parsing (#2997)
GitanjaliChhetri Nov 2, 2022
686fe7d
chore(release): publish [skip ci]
ohif-bot Nov 2, 2022
4473807
fix: handle missing ReferencedInstanceSequence attribute (#2786)
paulineribeyre Nov 12, 2022
6007f34
chore(release): publish [skip ci]
ohif-bot Nov 12, 2022
597ac11
fix: #2964 Reword message for segmentation error loading due to orien…
GitanjaliChhetri Dec 12, 2022
b9d484f
chore(release): publish [skip ci]
ohif-bot Dec 12, 2022
1278c6f
Merge pull request #171 from OHIF/master
GitanjaliChhetri Dec 12, 2022
1d29554
Re IDC #3067: Show eye-icon when segment label name is long (#3073)
GitanjaliChhetri Dec 21, 2022
4ffb50c
chore(release): publish [skip ci]
ohif-bot Dec 21, 2022
3350b1f
Re IDC #3047: update variable name for frame index (#3085)
GitanjaliChhetri Dec 21, 2022
cfa697a
chore(release): publish [skip ci]
ohif-bot Dec 21, 2022
dab095b
Re IDC #3088: Fix seg toggle visibility logic (#3101)
GitanjaliChhetri Jan 10, 2023
5d9e4c9
chore(release): publish [skip ci]
ohif-bot Jan 10, 2023
9344bee
Merge pull request #173 from OHIF/master
GitanjaliChhetri Jan 10, 2023
cb9aa6a
chore: update issue and PR templates (#3113)
sedghi Jan 11, 2023
70b71bd
remove redundant code to update studydatamanager
GitanjaliChhetri Jan 11, 2023
24bbf2b
Re IDC #3077: Seg series thumbnail selection (#3078)
GitanjaliChhetri Jan 17, 2023
30515b8
chore(release): publish [skip ci]
ohif-bot Jan 17, 2023
e654626
Merge pull request #174 from ImagingDataCommons/IDC2servers3098
GitanjaliChhetri Jan 17, 2023
3cf4f53
Merge pull request #176 from OHIF/master
GitanjaliChhetri Jan 17, 2023
43715e3
feat: Update Measurement Panel
GitanjaliChhetri Jan 30, 2023
c76bd04
enable measurement panel
GitanjaliChhetri Feb 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions .github/ISSUE_TEMPLATE/---bug-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,21 @@
name: "\U0001F41B Bug report"
about: Create a report to help us improve
title: ''
labels: 'Community: Report :bug:, Awaiting Reproduction, Triage :white_flag:'
labels: 'Community: Report :bug:, Awaiting Reproduction'
assignees: ''
---

> **Before Creating an issue**
>
> - Are you running the latest version?
> - Are you reporting to the correct repository?
> - Did you search existing issues?

## Bug Report
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://github.com/OHIF/Viewers/blob/master/CODE_OF_CONDUCT.md -->
<!-- 🕮 Read our guide about our process: https://v3-docs.ohif.org/development/our-process -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest version -->

### Describe the Bug

_A clear and concise description of what the bug is._

### What steps can we follow to reproduce the bug?
### Steps to Reproduce:

1. First step
2. Second step
Expand All @@ -28,6 +26,15 @@ _A clear and concise description of what the bug is._
Please use code blocks to show formatted errors or code snippets
```

### The current behavior

_A clear and concise description of what happens instead of the expected
behavior._

### The expected behavior

_A clear and concise description of what you expected to happen._

> :warning: Reports we cannot reproduce are at risk of being marked stale and
> closed. The more information you can provide, the more likely we are to look
> into and address your issue.
19 changes: 14 additions & 5 deletions .github/ISSUE_TEMPLATE/---feature-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,28 @@
name: "\U0001F680 Feature request"
about: Suggest an idea for this project
title: ''
labels: 'Community: Request :hand:, Triage :white_flag:'
labels: 'Community: Request :hand:'
assignees: ''
---

> :hand: Many people requests features. Tell us why yours is important to the
<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://github.com/OHIF/Viewers/blob/master/CODE_OF_CONDUCT.md -->

<!-- :hand: Many people requests features. Tell us why yours is important to the
> community. How does it add value? Why _this feature_?
>
> Is your request very specific to your needs? Consider
> [contributing it](https://docs.ohif.org/contributing.html) yourself! Or reach
> out to a community member that offers
> [contributing it](https://v3-docs.ohif.org/development/contributing) yourself!
> Or reach out to a community member that offers
> [consulting services](https://docs.ohif.org/help.html#paid--commercial).
-->

### Request

## Request
<!--
Please include as much detail as possible including possibly mock up screen shots, workflow or logic flow diagrams etc.
Discuss if and how the requested feature interacts with existing features
-->

**What feature or change would you like to see made?**

Expand Down
93 changes: 85 additions & 8 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,91 @@
### PR Checklist
<!-- Do Not Delete This! pr_template -->
<!-- Please read our Rules of Conduct: https://github.com/OHIF/Viewers/blob/master/CODE_OF_CONDUCT.md -->
<!-- 🕮 Read our guide about our Contributing Guide here https://v3-docs.ohif.org/development/contributing -->
<!-- :hand: Thank you for starting this amazing contribution! -->

- [ ] Brief description of changes
- [ ] Links to any relevant issues
- [ ] Required status checks are passing
- [ ] User cases if changes impact the user's experience
- [ ] `@mention` a maintainer to request a review
<!--
⚠️⚠️ Please make sure the checklist section below is complete before submitting your PR.
To complete the checklist, add an 'x' to each item: [] -> [x]
(PRs that do not have all the checkboxes marked will not be approved)
-->

### Context

<!--
Provide a clear explanation of the reasoning behind this change, such as:
- A link to the issue being addressed, using the format "Fixes #ISSUE_NUMBER"
- An image showing the issue or problem being addressed (if not already in the issue)
- Error logs or callStacks to help with the understanding of the problem (if not already in the issue)
-->

### Changes & Results

<!--
List all the changes that have been done, such as:
- Add new components
- Remove old components
- Update dependencies

What are the effects of this change?
- Before vs After
- Screenshots / GIFs / Videos
-->

### Testing

<!--
Describe how we can test your changes.
- open a URL
- visit a page
- click on a button
- etc.
-->

### Checklist

#### PR

<!--
Links
-->
https://semantic-release.gitbook.io/semantic-release/#how-does-it-work

Examples:
Please note the letter casing in the provided examples (upper or lower).

- feat(MeasurementService): add ...
- fix(Toolbar): fix ...
- docs(Readme): update ...
- style(Whitespace): fix ...
- refactor(ExtensionManager): ...
- test(HangingProtocol): Add test ...
- chore(git): update ...
- perf(VolumeLoader): ...

You don't need to have each commit within the Pull Request follow the rule,
but the PR title must comply with it, as it will be used as the commit message
after the commits are squashed.
-->

- [] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

#### Code

- [] My code has been well-documented (function documentation, inline comments,
etc.)

#### Public Documentation Updates

<!-- https://v3-docs.ohif.org/ -->

- [] The documentation page has been updated as necessary for any public API
additions or removals.

#### Tested Environment

- [] "OS: <!--[e.g. Windows 10, macOS 10.15.4]"-->
- [] "Node version: <!--[e.g. 16.14.0]"-->
- [] "Browser:
<!--[e.g. Chrome 83.0.4103.116, Firefox 77.0.1, Safari 13.1.1]"-->

<!-- prettier-ignore-start -->
[blog]: https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/
Expand Down
12 changes: 3 additions & 9 deletions .github/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,17 @@
# Number of days of inactivity before an issue becomes stale
daysUntilStale: 180
# Number of days of inactivity before a stale issue is closed
daysUntilClose: 9000
daysUntilClose: 60
# Issues with these labels will never be considered stale
exemptLabels:
- 'Story :raised_hands:'
- 'Bug: Verified :bug:'
- 'Task: CI/Tooling :robot:'
- 'Task: Docs 📖'
- 'Task: Docs :book:'
- 'Task: Refactor :hammer_and_wrench:'
- 'Task: Tests :microscope:'
- 'PR: Awaiting Review 👀'
- 'Triage :white_flag:'
- 'Extension: Discussion'
- 'Announcement 🎉'
- 'IDC:priority'
- 'IDC:candidate'
- 'IDC:collaboration'
- 'Community: Request :hand:'
- 'Community: Report :bug:'
# Label to use when marking an issue as stale
staleLabel: 'Stale :baguette_bread:'
# Comment to post when marking an issue as stale. Set to `false` to disable
Expand Down
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,8 @@ screenshots/

# Locize settings
.locize

# firebase
firebase.json
.firebase/
.firebaserc
24 changes: 24 additions & 0 deletions extensions/cornerstone/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,30 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [2.12.16](https://github.com/OHIF/Viewers/compare/@ohif/[email protected]...@ohif/[email protected]) (2022-12-21)

**Note:** Version bump only for package @ohif/extension-cornerstone





## [2.12.15](https://github.com/OHIF/Viewers/compare/@ohif/[email protected]...@ohif/[email protected]) (2022-09-20)

**Note:** Version bump only for package @ohif/extension-cornerstone





## [2.12.14](https://github.com/OHIF/Viewers/compare/@ohif/[email protected]...@ohif/[email protected]) (2022-09-01)

**Note:** Version bump only for package @ohif/extension-cornerstone





## [2.12.13](https://github.com/OHIF/Viewers/compare/@ohif/[email protected]...@ohif/[email protected]) (2022-06-30)

**Note:** Version bump only for package @ohif/extension-cornerstone
Expand Down
6 changes: 3 additions & 3 deletions extensions/cornerstone/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ohif/extension-cornerstone",
"version": "2.12.13",
"version": "2.12.16",
"description": "OHIF extension for Cornerstone",
"author": "OHIF",
"license": "MIT",
Expand Down Expand Up @@ -35,8 +35,8 @@
"cornerstone-core": "^2.6.1",
"cornerstone-math": "^0.1.9",
"cornerstone-tools": "^6.0.6",
"cornerstone-wado-image-loader": "^4.1.0",
"dcmjs": "0.19.9",
"cornerstone-wado-image-loader": "^4.2.1",
"dcmjs": "0.29.3",
"dicom-parser": "^1.8.11",
"hammerjs": "^2.0.8",
"prop-types": "^15.6.2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
left: 20px;
}
.OHIFCornerstoneViewportOverlay .bottom-left3 {
bottom: 110px;
bottom: 160px;
left: -20px;
}
.OHIFCornerstoneViewportOverlay .bottom-right {
Expand Down Expand Up @@ -71,3 +71,35 @@
width: 18px;
height: 18px;
}

#SRlabelcontainer {
position: relative;
}

#parent-button {
position: relative;
}

#parent-button.haschild::before {
content: "";
position: absolute;
left: -15px;
top: 50%;
transform: translateY(-50%);
width: 0;
height: 0;
border-left: 7px solid transparent;
border-right: 7px solid transparent;
border-top: 9px solid white;
}

#child-button {
position: absolute;
width: 100%;
max-height: 30;
overflow: hidden;
overflow-wrap: break-word;
white-space: normal;
left: 20px;
transition: height 0.3s;
}
Loading