Upgrade to rover cli #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2022 10:40
added 2 commits
January 26, 2022 12:06
piotrjak
approved these changes
Jan 26, 2022
| `--key=${apolloKey}` | ||
| ]); | ||
| process.env.APOLLO_KEY = apolloKey; | ||
| exec.execSync(`npx rover subgraph publish ${name}@${variant} --schema ${schema} --name ${service} --routing-url ${url}`, { |
There was a problem hiding this comment.
hmm, is this vulnerable to injections? what if name was ; echo $AWS_SECRET_KEY ?
There was a problem hiding this comment.
Could be however, in this case the user is always going to be the service owner and none of the arguments come from client input. You could just as well add an npm script to the build to echo AWS_SECRET_KEY too.
Perrogramador
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be called using exec since index.js is not defined for the @apollo/rover module (it downloads a platform specific binary at run time).
Tested in dev env