Add bilat_trade to iomath #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding functionality to iomath to pull out bilateral trade data
pymrio/tools/iomath.py
Outdated
| pandas.DataFrame | ||
| bilateral trade flows as a matrix showing region and sector of origin in rows, and region of import in columns | ||
|
|
||
| NOTE: ONLY IMPLEMENTED FOR DataFrame right now |
There was a problem hiding this comment.
In numpy docstrings (which you are using here, thats great), the notes would come before the Parameters like:
Notes
ONLY IMPLEMENTED FOR DataFrame right now
Parameters
...
small detail, if you want to change.
There was a problem hiding this comment.
done - hope that is OK!
konstantinstadler
requested changes
Nov 4, 2021
small desc update
|
thanks a lot, I will integrate it into the pymrio object |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functionality to iomath to pull out bilateral trade data. I have not updated the mriosystem or calc_all to include this routine in there yet. Perhaps check the naming of output variables for consistency (noting that "import" and "export" are used in a "net" sense elsewhere in iomath)