Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript typings #21

Closed
wants to merge 2 commits into from
Closed

Add TypeScript typings #21

wants to merge 2 commits into from

Conversation

zorji
Copy link

@zorji zorji commented Dec 5, 2019

I use err-code for TypeScript and it's been very convenient for me. I would like it to have the builtin TypeScript type.

@wemeetagain
Copy link

bump

Copy link

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satazor
Copy link
Member

satazor commented Jun 9, 2020

Hello @wemeetagain,

Thanks for the PR but I will have to close it as I’m not in favor of adding typescript types:

Sorry, hope you understand.

@satazor satazor closed this Jun 9, 2020
@zorji
Copy link
Author

zorji commented Jun 9, 2020

@satazor No problems, I can contribute this to @types.

Do you want me add you as a maintainer of the types? or are you fine for me to just put my name? See https://github.com/DefinitelyTyped/DefinitelyTyped#definition-owners

@wemeetagain
Copy link

@zorji I'm willing to help maintain. Will you make the PR soon? I'm planning on using these types soon/now.

@zorji
Copy link
Author

zorji commented Jun 16, 2020

@zorji I'm willing to help maintain. Will you make the PR soon? I'm planning on using these types soon/now.

sweet I'll create one now

@zorji zorji deleted the add-typings branch June 16, 2020 04:06
@zorji
Copy link
Author

zorji commented Jun 16, 2020

@wemeetagain PR is created here DefinitelyTyped/DefinitelyTyped#45504

@zorji zorji mentioned this pull request Apr 22, 2021
@zorji
Copy link
Author

zorji commented Apr 22, 2021

@wemeetagain err-code provide official type since v3.0.0, I've created a PR to remove it in @types DefinitelyTyped/DefinitelyTyped#52518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants