-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript typings #21
Conversation
bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hello @wemeetagain, Thanks for the PR but I will have to close it as I’m not in favor of adding typescript types:
Sorry, hope you understand. |
@satazor No problems, I can contribute this to @types. Do you want me add you as a maintainer of the types? or are you fine for me to just put my name? See https://github.com/DefinitelyTyped/DefinitelyTyped#definition-owners |
@zorji I'm willing to help maintain. Will you make the PR soon? I'm planning on using these types soon/now. |
sweet I'll create one now |
@wemeetagain PR is created here DefinitelyTyped/DefinitelyTyped#45504 |
@wemeetagain err-code provide official type since v3.0.0, I've created a PR to remove it in @types DefinitelyTyped/DefinitelyTyped#52518 |
I use err-code for TypeScript and it's been very convenient for me. I would like it to have the builtin TypeScript type.